Re: libpq build problem with <io.h> on MS VC++

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andrew Francis <locust(at)familyhealth(dot)com(dot)au>, pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq build problem with <io.h> on MS VC++
Date: 2004-08-17 04:51:28
Message-ID: 29241.1092718288@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Ah, one thing we have done is to reference everything as pg* and define
> it to be the libc function on unix and give a compatibility function on
> Win32. We do that with pgpipe. That might be our best solution.

We should do that sort of thing only as a very last resort. It's
particularly bad when we cannot easily enforce that all references use
the pgxxx function. pgpipe is manageable because there are very few
places that need to use it, but the same cannot be said of rename.

Personally I'd rather get rid of pgpipe as well ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Christian Klemke 2004-08-17 09:41:21 Re: our friend the win32 system timer.
Previous Message Tom Lane 2004-08-17 04:42:50 Re: libpq build problem with <io.h> on MS VC++

Browse pgsql-patches by date

  From Date Subject
Next Message PostgreSQL Bugs List 2004-08-17 07:20:15 BUG #1219: pgxs does not work fully
Previous Message Tom Lane 2004-08-17 04:42:50 Re: libpq build problem with <io.h> on MS VC++