| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Prompt for password on Windows platforms |
| Date: | 2006-02-28 21:18:25 |
| Message-ID: | 29192.1141161505@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Magnus Hagander wrote:
>> (Specifically, it's bad that we open /dev/tty for writing even if we
>> failed it for reading (that will create a new file), and that we don't
>> check if it's a tty at all).
> Maybe we should stat the file and check that it's actually a character
> special device.
On any sane Unix installation, /dev is not user-writable ... and I've
never heard of one without /dev/tty, either. So the above risk seems
illusory, except on Windows.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-02-28 21:22:17 | Re: [PATCH] Prompt for password on Windows platforms |
| Previous Message | Magnus Hagander | 2006-02-28 21:11:49 | Re: [PATCH] Prompt for password on Windows platforms |