Skip site navigation (1) Skip section navigation (2)

Re: Adding a --quiet option to initdb

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Hallgren <thomas(at)tada(dot)se>
Cc: "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, James William Pye <james(dot)pye(at)icrossing(dot)com>, Devrim GUNDUZ <devrim(at)commandprompt(dot)com>, James William Pye <pgsql(at)jwp(dot)name>
Subject: Re: Adding a --quiet option to initdb
Date: 2006-01-27 16:20:17
Message-ID: 2898.1138378817@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
I wrote:
>> While we can probably all agree that it's not very interesting to
>> mention every single directory that initdb creates, I find it ...

I took a quick look at the source and see that it would be trivial
to reduce the current output from

creating directory /home/postgres/v82/data ... ok
creating directory /home/postgres/v82/data/global ... ok
creating directory /home/postgres/v82/data/pg_xlog ... ok
creating directory /home/postgres/v82/data/pg_xlog/archive_status ... ok
creating directory /home/postgres/v82/data/pg_clog ... ok
creating directory /home/postgres/v82/data/pg_subtrans ... ok
creating directory /home/postgres/v82/data/pg_twophase ... ok
creating directory /home/postgres/v82/data/pg_multixact/members ... ok
creating directory /home/postgres/v82/data/pg_multixact/offsets ... ok
creating directory /home/postgres/v82/data/base ... ok
creating directory /home/postgres/v82/data/base/1 ... ok
creating directory /home/postgres/v82/data/pg_tblspc ... ok
selecting default max_connections ... 100
...

to

creating directory /home/postgres/v82/data ... ok
creating subdirectories ... ok
selecting default max_connections ... 100
...

which would go a long way to cutting down the perception of useless
chatter.  I think the per-subdirectory messages were put in at a time
when we only created one or two such, but that was a long time ago.
It doesn't take long to make a directory, so the messages aren't
very useful as progress reports, and if the first creation succeeds
then it's highly unlikely the rest will fail.  (Of course, if one
does fail we'll report its name at that point.)

Barring objections I'll make this change, regardless of whether we
later decide that all the progress messages ought to be dependent
on a --verbose or --quiet flag.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2006-01-27 16:27:10
Subject: Re: stats for failed transactions (was Re: [GENERAL] VACUUM Question)
Previous:From: Tom LaneDate: 2006-01-27 15:56:12
Subject: Re: stats for failed transactions (was Re: [GENERAL] VACUUM Question)

pgsql-patches by date

Next:From: Tom LaneDate: 2006-01-27 16:43:24
Subject: Re: Patch for ALTER TABLE / TYPE
Previous:From: Alvaro HerreraDate: 2006-01-27 15:56:10
Subject: Re: Adding a --quiet option to initdb

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group