Re: [HACKERS] [PATCHES] log_statement output for protocol

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oliver Jowett <oliver(at)opencloud(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Dave Cramer <pg(at)fastcrypt(dot)com>, Csaba Nagy <nagy(at)ecircle-ag(dot)com>, Postgres JDBC <pgsql-jdbc(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] log_statement output for protocol
Date: 2006-08-05 16:27:25
Message-ID: 28967.1154795245@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc pgsql-patches

Oliver Jowett <oliver(at)opencloud(dot)com> writes:
> A 50-parameter query could be .. interesting ..

> I realize that you need this level of output to reflect what is
> happening at the protocol level, but seeing all the protocol detail is
> not really what you expect when you turn on basic statement logging, is it?

Well, we've certainly been beat up often enough about the lack of
logging bind parameter values --- I don't think there's any question
about the importance of printing them. I agree that the proposed format
is much too verbose though. In particular, a separate LOG message per
parameter is NOT what I had in mind; I want them in DETAIL lines of the
bind log message. (This'd perhaps also address Oliver's issue, since
if you didn't want to see the values you could turn down
log_error_verbosity.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2006-08-05 16:56:35 Re: ecpg test suite
Previous Message Tom Lane 2006-08-05 16:22:02 Re: 8.2 features status

Browse pgsql-jdbc by date

  From Date Subject
Next Message Bruce Momjian 2006-08-05 17:39:06 Re: [HACKERS] [PATCHES] log_statement output for protocol
Previous Message David Fetter 2006-08-05 15:59:10 Re: [HACKERS] [PATCHES] log_statement output for protocol

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-08-05 17:39:06 Re: [HACKERS] [PATCHES] log_statement output for protocol
Previous Message David Fetter 2006-08-05 15:59:10 Re: [HACKERS] [PATCHES] log_statement output for protocol