Skip site navigation (1) Skip section navigation (2)

Re: pgsql/src/include parser/parse_coerce.h catalo ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: inoue(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/include parser/parse_coerce.h catalo ...
Date: 2001-09-30 00:03:43
Message-ID: 28594.1001808223@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
inoue(at)postgresql(dot)org writes:
> Modified files:
> 	src/include/parser: parse_coerce.h 
> 	src/include/catalog: pg_operator.h 
> Log message:
> 	Allow comparison between xid and xid, int.

I do not think it's a good idea to define xid and int as
binary-compatible.  If it is a good idea then you did it wrong
--- IS_BINARY_COMPATIBLE needs to test for both directions.

But what I'd suggest is to undo the IS_BINARY_COMPATIBLE change
and instead add another pg_operator entry that accepts xid = int4,
mapping it to xideq.  That gets the job done without opening up
a morass of binary-compatibility issues.

			regards, tom lane

In response to

pgsql-committers by date

Next:From: momjianDate: 2001-09-30 00:45:48
Subject: pgsql/ oc/TODO rc/backend/storage/lmgr/deadloc ...
Previous:From: tglDate: 2001-09-29 23:49:52
Subject: pgsql/src/backend/access/nbtree nbtinsert.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group