From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Magnus Hagander <magnus(at)hagander(dot)net>
Cc:
Fujii Masao <masao(dot)fujii(at)gmail(dot)com>,
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: Streaming Replication on win32
Date:
2010-02-15 16:21:04
Message-ID:
284.1266250864@sss.pgh.pa.us (view raw or flat )
Thread:
2010-01-17 13:58:14 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-17 20:22:06 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-01-18 09:30:36 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-01-18 09:40:11 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-18 10:11:39 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-01-18 14:46:02 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-18 15:33:56 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-01-21 12:46:17 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-01-22 01:03:56 from Joe Conway <mail(at)joeconway(dot)com>
2010-01-22 06:33:50 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-01-22 06:49:01 from Joe Conway <mail(at)joeconway(dot)com>
2010-01-22 07:19:06 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-01-22 09:00:50 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-01-22 10:28:29 from Marko Kreen <markokr(at)gmail(dot)com>
2010-01-22 11:34:26 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-01-24 22:33:39 from Joe Conway <mail(at)joeconway(dot)com>
2010-01-24 22:36:52 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-24 23:03:11 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-25 06:47:40 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-08 09:39:49 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-14 14:52:30 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-15 05:57:54 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-15 15:50:36 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-15 16:21:04 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-15 16:33:24 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-16 02:02:20 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-16 19:26:07 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-18 04:21:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-18 14:43:32 from Magnus Hagander <magnus(at)hagander(dot)net>
Lists:
pgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> I changed your patch to this, because I find it a lot simpler. The
> change is in the checking in pgwin32_recv - there is no need to ever
> call waitforsinglesocket, we can just exit out early.
> Do you see any issue with that?
This definitely looks cleaner, but is there a reason not to use bool
instead of int here?
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Magnus HaganderDate: 2010-02-15 16:31:16
Subject : RADIUS secret in file
Previous :From : Robert HaasDate : 2010-02-15 16:18:40
Subject : Re: TCP keepalive support for libpq