From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc:
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,
Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject:
Re: Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
Date:
2010-02-17 17:07:34
Message-ID:
28369.1266426454@sss.pgh.pa.us (view raw or flat )
Thread:
2008-12-05 14:41:16 from "Randy Isbell" <jisbell(at)cisco(dot)com>
2008-12-06 04:29:10 from "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
2009-01-15 01:50:31 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-01-15 12:09:57 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2009-01-15 14:15:55 from "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
2009-01-15 15:23:46 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2009-01-15 16:15:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-15 17:33:44 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2009-01-15 17:43:06 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-01-15 17:51:35 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2009-01-16 02:18:49 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2009-01-16 02:42:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-16 03:18:38 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2009-01-15 14:25:29 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2009-01-15 23:54:03 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-04 07:28:03 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-05 00:08:35 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-02-05 00:54:14 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-16 05:19:15 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-17 08:43:19 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-02-17 17:07:34 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-15 09:40:36 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Lists:
pgsql-bugs pgsql-docs pgsql-hackers
Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> I'd like to apply the patch to HEAD and previous releases because
> the issue seems to be a bug in the core. Any comments or objections?
The proposed patch seems quite ugly to me; not only the messy coding,
but the fact that it might return either the segment containing the
XLOG_BACKUP_END record or the next one.
I think an appropriate fix might just be s/XLByteToSeg/XLByteToPrevSeg/,
so that the result is always the segment containing the XLOG_BACKUP_END
record even when the record ends exactly at a segment boundary.
regards, tom lane
In response to
pgsql-docs by date
Next :From: Greg SmithDate: 2010-02-18 08:11:21Subject : Hot Standby documentation updatesPrevious :From : Takahiro ItagakiDate : 2010-02-17 08:43:19Subject : Re: Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
pgsql-hackers by date
Next :From: Peter EisentrautDate: 2010-02-17 17:39:12Subject : Re: codlin_month is up and complain - PL/Python crashPrevious :From : Tom LaneDate : 2010-02-17 16:26:00Subject : Re: codlin_month is up and complain - PL/Python crash
pgsql-bugs by date
Next :From: Chris TraversDate: 2010-02-17 17:41:29Subject : Re: BUG #5331: Integer overflow in tmie counterPrevious :From : Sivaguru SankaridurgDate : 2010-02-17 16:10:20Subject : Re: BUG #5332: Installation weirdness
