Skip site navigation (1) Skip section navigation (2)

Re: BUG #5206: wal_sync_method in stock postgresql.conf may be wrong

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5206: wal_sync_method in stock postgresql.conf may be wrong
Date: 2009-11-24 00:25:09
Message-ID: 28366.1259022309@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Nov 20, 2009 at 6:56 PM, Alvaro Herrera <alvherre(at)postgresql(dot)org> wrote:
>> I have two suggestions to fix this:
>> 
>> 1. avoid displaying any value at all as if it were the true default (this
>> would perhaps make the line invalid were the user to uncomment it)
>> 
>> 2. change initdb so that it modifies that line too (along with
>> shared_buffers etc) to put the actual default value in there, but without
>> uncommenting it.
>> 
>> I also have one non-suggestion:
>> 
>> 3. do nothing

> I like #3 or #1 better than #2.   Putting logic into initdb to edit
> the comments in the file doesn't really seem like a worthwhile use of
> time.

I agree, it seems like more work than the problem is worth.  We could
change the entry to something like

#wal_sync_method = (platform-dependent)	# the default is ...

> (I still think we should get rid of the commented-out settings
> altogether, but that's another argument...)

That's another reason not to expend work here --- it still seems
fairly likely that that might happen.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Daniel FarinaDate: 2009-11-24 00:25:31
Subject: Re: [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION
Previous:From: Tom LaneDate: 2009-11-24 00:20:05
Subject: Re: [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

pgsql-bugs by date

Next:From: lee brownDate: 2009-11-24 11:04:58
Subject: BUG #5211: invalid password
Previous:From: Robert HaasDate: 2009-11-23 22:11:49
Subject: Re: BUG #5206: wal_sync_method in stock postgresql.conf may be wrong

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group