Skip site navigation (1) Skip section navigation (2)

Re: pg_dump UDT/function dependency patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_dump UDT/function dependency patch
Date: 2001-04-01 01:22:56
Message-ID: 28364.986088176@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> Patch to put rudimentary dependency support into pg_dump. This addresses
> the UDT/function order problem. Unfortunately, this is not a small patch so
> I would prefer some debate about whether it should be applied 7.1.

Looks good to me.  A large part of the bulk appears to be changes to
not treat OIDs as integers, which is a necessary bug fix anyway.

One small stylistic quibble:

+#define oidcmp(x,y) ( (x < y ? -1 : (x > y) ?  1 : 0))
+#define oideq(x,y) (x == y)

These need more parentheses to be safe:

+#define oidcmp(x,y) ( ((x) < (y) ? -1 : ((x) > (y)) ?  1 : 0))
+#define oideq(x,y) ((x) == (y))

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Philip WarnerDate: 2001-04-01 05:44:21
Subject: Re: pg_dump UDT/function dependency patch
Previous:From: Philip WarnerDate: 2001-03-31 14:45:31
Subject: pg_dump UDT/function dependency patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group