Re: pgsql: plpython: Add SPI cursor support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Jan Urbański <wulczer(at)wulczer(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org, Steve Singer <ssinger(at)ca(dot)afilias(dot)info>
Subject: Re: pgsql: plpython: Add SPI cursor support
Date: 2012-01-09 16:57:26
Message-ID: 28255.1326128246@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 01/09/2012 10:52 AM, Dave Page wrote:
>> Yes, it's defined as such:
>> PyAPI_FUNC(PyObject *) PyObject_SelfIter(PyObject *);

> Hmm. Well, at this stage I'm slightly inclined to say it's a compiler
> problem. That's a pretty old compiler. If you can't upgrade it maybe you
> should just take --with-python out of the buildfarm settings.

I'm wondering what PyAPI_FUNC() expands to on Dave's machine. In my
copy of pyport.h, there's a rat's nest of cygwin-related tests that may
or may not lead to including "extern" and/or "__declspec" in that macro.
I think possibly the wrong combination might lead to failures of this
ilk?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Dave Page 2012-01-09 17:06:54 Re: pgsql: plpython: Add SPI cursor support
Previous Message Andrew Dunstan 2012-01-09 16:43:51 Re: pgsql: plpython: Add SPI cursor support

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2012-01-09 17:06:54 Re: pgsql: plpython: Add SPI cursor support
Previous Message Andrew Dunstan 2012-01-09 16:43:51 Re: pgsql: plpython: Add SPI cursor support