Skip site navigation (1) Skip section navigation (2)

Re: More heap tuple header fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Manfred Koizar <mkoi-pg(at)aon(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: More heap tuple header fixes
Date: 2002-07-22 15:06:38
Message-ID: 28255.1027350398@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Manfred Koizar <mkoi-pg(at)aon(dot)at> writes:
> On Sat, 20 Jul 2002 16:27:14 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> wrote:
>> I'd recommend redesigning the HeapTupleHeaderSet macros so that they
>> do not do any setting of t_infomask bits, or even take any conditional
>> action based on them,

> The HEAP_XMIN_IS_XMAX bit is exclusively managed by these macros.
> Pulling the handling of this bit out of the macros and spreading it to
> the places, where the macros are used, cannot make the whole thing
> more robust.  This would mean, the caller had to decide whether to
> store Cmax into t_cid or t_xmax...

But the present scheme is very obviously not robust.

> Anyway, with this patch applied the heap tuple header changes should
> be able to survive the next two weeks.  I don't want to hack together
> a quick change now, before I go on vacation.  Let's find the perfect
> solution, when I'm back ...

I'm on the road too.  But I want to see a different solution before
we release.  I do not trust the current code at all.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2002-07-22 15:18:55
Subject: Re: Demo patch for DROP COLUMN
Previous:From: Christopher Kings-LynneDate: 2002-07-22 02:22:40
Subject: Re: Demo patch for DROP COLUMN

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group