Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] openbsd 3.2, postgresql 7.3beta3 and openssl 'e_os.h' include

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,Peter Galbavy <peter(dot)galbavy(at)knowtion(dot)net>,pgsql-ports(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] openbsd 3.2, postgresql 7.3beta3 and openssl 'e_os.h' include
Date: 2002-11-07 18:49:40
Message-ID: 28017.1036694980@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-ports
I said:
> Anyway, get_last_socket_error() seems exactly equivalent to our macro
> SOCK_ERRNO in libpq/libpq-int.h.  AFAICT, the uses of it in our
> code are these:

> /home/postgres/pgsql/src/backend/libpq/be-secure.c:
> errno = get_last_socket_error();
> /home/postgres/pgsql/src/backend/libpq/be-secure.c:
> errno = get_last_socket_error();
> /home/postgres/pgsql/src/interfaces/libpq/fe-secure.c:
> SOCK_ERRNO = get_last_socket_error();
> /home/postgres/pgsql/src/interfaces/libpq/fe-secure.c:
> SOCK_ERRNO = get_last_socket_error();

> and I think every one of these is bogus and should be removed.
> At best they're no-ops.

> If that is the only use of e_os.h stuff then we can stop including
> the file ...

These were indeed the only uses of e_os.h symbols.  I have removed them
and the #includes.

			regards, tom lane

In response to

pgsql-ports by date

Next:From: Larry RosenmanDate: 2002-11-07 21:17:28
Subject: Re: [HACKERS] PostgreSQL supported platform report and a
Previous:From: Larry RosenmanDate: 2002-11-07 17:23:13
Subject: Re: [HACKERS] PostgreSQL supported platform report and a

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-11-07 19:15:29
Subject: Re: RC1 on Friday?
Previous:From: Alvaro HerreraDate: 2002-11-07 18:47:23
Subject: Re: Outstanding patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group