| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, "devrim(at)gunduz(dot)org" <devrim(at)gunduz(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries. |
| Date: | 2012-09-16 12:10:38 |
| Message-ID: | 27AF9583-3084-4EE1-BC45-6F69A2DB076C@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sep 15, 2012, at 11:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Right, but we do a shutdown checkpoint at the end of crash recovery.
Yes, but that only writes the buffers that are dirty. It doesn't fix the lack of a BM_PERMANENT flag on a buffer that ought to have had one. So that page can now get modified AGAIN, after recovery, and not checkpointed.
> I could believe that this case gets missed, but it's not clear from
> what's been said --- and if that case *is* broken, there should have
> been a whole lot more corruption reports recently than what we've seen.
It's pretty clear from Jeff's example at the top of the thread, which involves two crashes and no archive recovery.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2012-09-16 17:33:43 | pgsql: Fix documentation reference to maximum allowed for autovacuum_fr |
| Previous Message | Tom Lane | 2012-09-16 04:32:18 | Re: Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2012-09-16 13:49:35 | Patch to include c.h |
| Previous Message | Amit kapila | 2012-09-16 06:10:43 | Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown |