Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch Submission Guidelines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch Submission Guidelines
Date: 2006-02-16 14:48:54
Message-ID: 27991.1140101334@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> On Thursday 16 February 2006 00:27, Tom Lane wrote:
>> * avoid unnecessary whitespace changes.  They just distract the
>> reviewer, and your formatting changes will probably not survive
>> the next pgindent run anyway.

> would diff -c --ignore-space-change be better?

Hmm.  Not sure --- there are situations where whitespace *does* matter,
so having that as a blanket policy doesn't seem wise.  Also I'm worried
that a diff made this way would confuse patch (for instance, because
line numbers following an omitted whitespace change wouldn't match up).
Probably best not to go there, but just focus on the point about keeping
the patch readable.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Gary DoadesDate: 2006-02-16 15:42:36
Subject: Re: [HACKERS] qsort again (was Re: Strange Create Index
Previous:From: Martijn van OosterhoutDate: 2006-02-16 14:48:33
Subject: Re: qsort again (was Re: [PERFORM] Strange Create Index

pgsql-patches by date

Next:From: Pavel StehuleDate: 2006-02-16 19:36:34
Subject: how solve diff of API counstruct_md_array between 8.1 and 8.2?
Previous:From: Alvaro HerreraDate: 2006-02-16 14:38:26
Subject: Re: Patch Submission Guidelines

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group