Re: [COMMITTERS] pgsql: Disable _FORTIFY_SOURCE with ICC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Subject: Re: [COMMITTERS] pgsql: Disable _FORTIFY_SOURCE with ICC
Date: 2012-10-05 03:37:58
Message-ID: 27946.1349408278@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> I've seen this warning in recent Fedora builds, though not on my F16
> production box. Some googling suggests the locution

> #if __OPTIMIZE__
> #define _FORTIFY_SOURCE 2
> #endif

> but I've not tested that.

A bit later: testing on an F17 box (glibc-2.15-56.fc17.x86_64)
confirms Peter G's complaint, and also confirms that putting
the above into port/linux.h (instead of the template file) fixes the
problem. Don't know how to disable it on ICC, but I suppose there's
some way to test for ICC via an #if.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-10-05 14:26:07 pgsql: Use the regular main processing loop also in walsenders.
Previous Message Tom Lane 2012-10-05 03:22:25 Re: [COMMITTERS] pgsql: Disable _FORTIFY_SOURCE with ICC

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2012-10-05 05:12:56 Re: Sharing more infrastructure between walsenders and regular backends (was Re: Switching timeline over streaming replication)
Previous Message Tom Lane 2012-10-05 03:22:25 Re: [COMMITTERS] pgsql: Disable _FORTIFY_SOURCE with ICC