Re: Include tablespace information in psql \d footers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Include tablespace information in psql \d footers
Date: 2004-06-25 22:12:57
Message-ID: 2780.1088201577@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> Attached.

Couple of problems with this:

1. Don't #ifndef WIN32 it. In the first place, we might have tablespace
support on Windows later, and in the second place, even if psql is
running on Windows that doesn't mean the server it's talking to is.

2. Printing "pg_default" when reltblspace is zero is wrong. Get the
database's default tablespace and print that. Or perhaps better,
don't print anything at all; that would avoid cluttering the display
for people who don't use tablespaces.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2004-06-26 04:42:28 Re: nested xacts and phantom Xids
Previous Message Simon Riggs 2004-06-25 20:57:36 Re: tz error prevents postmaster.c compiling...