Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Date: 2011-01-26 22:47:10
Message-ID: 27675.1296082030@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On lr, 2011-01-22 at 16:36 -0500, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> Get rid of the global variable holding the error state

>> The buildfarm doesn't like this patch one bit.

> I have verified your adjustments and fixed up the rest.

I was a bit disturbed by the fact that fixing only one of the four
variant files was enough to turn the whole buildfarm green. Are the
other three cases even needed anymore? If so, how can we get some
coverage on them?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-01-26 23:08:02 Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Previous Message Peter Eisentraut 2011-01-26 22:42:55 Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-01-26 22:54:43 Re: ALTER TYPE 3: add facility to identify further no-work cases
Previous Message Alex Hunsaker 2011-01-26 22:44:05 Re: arrays as pl/perl input arguments [PATCH]