Re: TODO item: list prepared queries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Joachim Wieland <joe(at)mcknight(dot)de>, pgsql-patches(at)postgresql(dot)org
Subject: Re: TODO item: list prepared queries
Date: 2006-01-02 04:06:48
Message-ID: 27638.1136174808@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> The docs need some improvement, but I'm not aware of any major remaining
> issues with the patch.

I object VERY strongly to the part of the patch that inserts a
deparse_query_list() call into exec_parse_message(). That is not a
cheap operation, and imposing that sort of overhead on every Parse
message is entirely unacceptable from a performance point of view.

I see no need for it either. What's wrong with regurgitating the
original source string, which is already saved in prepared queries?

Other than that show-stopper, the patch looks reasonable at first glance.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2006-01-02 16:49:23 Re: [PATCHES] default resource limits
Previous Message Neil Conway 2006-01-02 02:15:24 Re: TODO item: list prepared queries