Jason Tishler <jason(at)tishler(dot)net> writes:
> I just checked one of my old favorites, "The UNIX Programming
> Environment," by Kernighan and Pike, 1984. It appears that "until"
> is understood by the Bourne shell back then, so its use should be OK.
Yeah, that's what I thought. I ended up applying the attached patch;
this not only avoids the timing problem but has more reliable detection
of postmaster startup failure than the original code.
regards, tom lane
*** src/test/regress/pg_regress.sh.orig Sun Sep 16 12:11:11 2001
--- src/test/regress/pg_regress.sh Thu Jan 3 16:52:05 2002
*** 353,358 ****
--- 353,379 ----
"$bindir/postmaster" -D "$PGDATA" -F $postmaster_options >"$LOGDIR/postmaster.log" 2>&1 &
+ # Wait till postmaster is able to accept connections (normally only
+ # a second or so, but Cygwin is reportedly *much* slower). Don't
+ # wait forever, however.
+ until "$bindir/psql" $psql_options template1 </dev/null 2>/dev/null
+ i=`expr $i + 1`
+ if [ $i -ge $max ]
+ if kill -0 $postmaster_pid >/dev/null 2>&1
+ : still starting up
+ sleep 1
if kill -0 $postmaster_pid >/dev/null 2>&1
echo "running on port $PGPORT with pid $postmaster_pid"
*** 363,371 ****
(exit 2); exit
- # give postmaster some time to pass WAL recovery
- sleep 3
else # not temp-install
--- 384,389 ----
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2002-01-03 22:00:42|
|Subject: Re: pg_regress.sh startup failure patch |
|Previous:||From: Ross Thomas||Date: 2002-01-03 20:38:37|
|Subject: Re: Patch for ODBC driver (look for odbc.ini in more than|