Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).
Date: 2010-01-06 22:11:23
Message-ID: 27568.1262815883@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
rhaas(at)postgresql(dot)org (Robert Haas) writes:
> Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

With this patch, a CLOBBER_CACHE_ALWAYS build starts falling apart all
over the place :-(.  Looks like you blew the memory management somehow;
it appears to be using a previously pfree'd pointer:

#3  0x00000000006cde28 in pfree (pointer=0x7f7f7f7f7f7f7f7f) at mcxt.c:581
#4  0x00000000006ad4f3 in InvalidateTableSpaceCacheCallback (
    arg=<value optimized out>, cacheid=<value optimized out>, 
    tuplePtr=<value optimized out>) at spccache.c:61
#5  0x00000000006a63eb in InvalidateSystemCaches () at inval.c:552
#6  0x00000000006a6451 in AcceptInvalidationMessages () at inval.c:720
#7  0x00000000005fed1a in LockRelationOid (relid=1213, lockmode=1) at lmgr.c:91
#8  0x000000000046ce09 in relation_open (relationId=1213, lockmode=1)
    at heapam.c:899
#9  0x000000000046ce74 in heap_open (relationId=13656, lockmode=13656)
    at heapam.c:1073
#10 0x00000000006a5210 in SearchCatCache (cache=0x1364a40, v1=1663, 
    v2=<value optimized out>, v3=0, v4=0) at catcache.c:1223
#11 0x00000000006ad959 in SearchSysCache (cacheId=42, key1=1663, key2=0, 
    key3=0, key4=0) at syscache.c:874
#12 0x00000000006ad366 in get_tablespace (spcid=13656) at spccache.c:128
#13 get_tablespace_page_costs (spcid=13656) at spccache.c:164
#14 0x00000000005a8a80 in cost_seqscan (path=0x13cc2b0, 
    root=<value optimized out>, baserel=0x13ae328) at costsize.c:186
#15 0x00000000005cb538 in create_seqscan_path (root=0x13af090, rel=0x13ae328)
    at pathnode.c:404
#16 0x00000000005a48eb in set_plain_rel_pathlist (rte=<value optimized out>, 
    rel=<value optimized out>, root=<value optimized out>) at allpaths.c:258
#17 set_rel_pathlist (rte=<value optimized out>, rel=<value optimized out>, 
    root=<value optimized out>) at allpaths.c:201
#18 0x00000000005a4b3e in set_base_rel_pathlists (root=<value optimized out>)
    at allpaths.c:157
#19 make_one_rel (root=<value optimized out>) at allpaths.c:93
#20 0x00000000005b8cf0 in query_planner (root=0x13af090, tlist=0x13cbb90, 
    tuple_fraction=<value optimized out>, limit_tuples=<value optimized out>, 
    cheapest_path=<value optimized out>, sorted_path=<value optimized out>, 
    num_groups=0x7fffa31aeec8) at planmain.c:254
#21 0x00000000005b9f1e in grouping_planner (root=0x13af090, 
    tuple_fraction=<value optimized out>) at planner.c:1087
#22 0x00000000005bbc90 in subquery_planner (glob=<value optimized out>, 
    parse=0x13ae440, parent_root=0x0, hasRecursion=88 'X', 
    tuple_fraction=<value optimized out>, subroot=<value optimized out>)
    at planner.c:506
#23 0x00000000005bbea5 in standard_planner (parse=0x13ae440, cursorOptions=0, 
...

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Marko TiikkajaDate: 2010-01-06 22:13:22
Subject: Re: Testing with concurrent sessions
Previous:From: David E. WheelerDate: 2010-01-06 22:10:15
Subject: Re: Testing with concurrent sessions

pgsql-committers by date

Next:From: Tom LaneDate: 2010-01-06 22:27:09
Subject: pgsql: Access hash entry before freeing it, not after.
Previous:From: Tom LaneDate: 2010-01-06 22:02:45
Subject: pgsql: Make error messages for bad --set-version argument more useful.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group