Skip site navigation (1) Skip section navigation (2)

Re: New warning in pg_dump

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>,Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New warning in pg_dump
Date: 2004-08-24 03:27:48
Message-ID: 27487.1093318068@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> At 01:58 AM 24/08/2004, Alvaro Herrera wrote:
>> static int _isIdentChar(unsigned char c)

> I think the correct thing to do is to leave it as (signed) char, and remove 
> the comparison to \200 = -127.

No, that isn't the right thing, because not all platforms think char is
signed.  I prefer declaring it as unsigned, which means you drop the
\377 end instead ...

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Philip WarnerDate: 2004-08-24 03:32:07
Subject: Re: New warning in pg_dump
Previous:From: Tom LaneDate: 2004-08-24 03:21:28
Subject: Re: auto-casting a bit more intelligent in 8.0 ... ?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group