Re: Eliminate more detoast copies for packed varlenas

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Eliminate more detoast copies for packed varlenas
Date: 2007-09-21 22:53:56
Message-ID: 27477.1190415236@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> Ok, this removes what should be most if not all of the call sites where we're
> detoasting text or byteas. In particular it gets all the regexp/like functions
> and all the trim/pad functions. It also gets hashtext and hash_any.

Applied with some fixes --- you'd missed like_match.c, which doubtless
explains Guillame's complaint that it didn't work ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-09-21 23:09:02 Re: Text <-> C string
Previous Message Alvaro Herrera 2007-09-21 21:45:49 Re: Open issues for HOT patch

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-21 23:09:02 Re: Text <-> C string
Previous Message Brendan Jurd 2007-09-21 21:02:20 Re: Text <-> C string