Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Interval->day docs and regression tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Glaesemann <grzm(at)myrealbox(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [PATCHES] Interval->day docs and regression tests
Date: 2005-07-30 16:56:23
Message-ID: 27443.1122742583@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Michael Glaesemann <grzm(at)myrealbox(dot)com> writes:
> Please find attached diffs for documentation and simple regression  
> tests for the new interval->day changes.

The buildfarm results suggest that justify_days is broken in the
integer-datetimes case, eg from panda:

*** ./expected/interval.out     Sat Jul 30 16:20:48 2005
--- ./results/interval.out      Sat Jul 30 16:24:31 2005
***************
*** 238,243 ****
  SELECT justify_days(interval '6 months 36 days 5 hours 4 minutes 3 seconds') as "7 mons 6 days 5 hours 4 mins 3 seconds";
   7 mons 6 days 5 hours 4 mins 3 seconds 
  ----------------------------------------
!  @ 7 mons 6 days 5 hours 4 mins 3 secs
  (1 row)
  
--- 238,243 ----
  SELECT justify_days(interval '6 months 36 days 5 hours 4 minutes 3 seconds') as "7 mons 6 days 5 hours 4 mins 3 seconds";
   7 mons 6 days 5 hours 4 mins 3 seconds 
  ----------------------------------------
!  @ 1 mon 186 days 5 hours 4 mins 3 secs
  (1 row)
  

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2005-07-30 17:49:30
Subject: Re: Write past chunk end?
Previous:From: Alvaro HerreraDate: 2005-07-30 16:51:56
Subject: Re: [HACKERS] Autovacuum loose ends

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-07-30 17:04:28
Subject: Re: P.tch to mention cost-based delay in vacuum reference
Previous:From: Alvaro HerreraDate: 2005-07-30 16:51:56
Subject: Re: [HACKERS] Autovacuum loose ends

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group