Re: pg_dump end comment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump end comment
Date: 2004-03-30 05:29:00
Message-ID: 27371.1080624540@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> This might seem a bit silly, but is there any chance we could add a
> comment at the end of pg_dump text output that says '-- End of dump'?

Sure --- while you're at it, put a "beginning of dump" at the start.

Is it worth adding the database name and/or other command-line
parameters given to pg_dump?

One thing to think about is the difference between a bare pg_dump and a
pg_dump/pg_restore sequence. Should these always generate identical
text output? (They do as of CVS tip, I believe, though this was not
always true before.)

Possibly this is all gilding the lily though...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-03-30 05:33:37 Re: pg_dump end comment
Previous Message Sean Chittenden 2004-03-30 04:27:54 Re: PostgreSQL and FreeBSD SoftUpdates

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-03-30 05:33:37 Re: pg_dump end comment
Previous Message Christopher Kings-Lynne 2004-03-30 03:37:45 pg_dump end comment