Re: float4/float8/int64 passed by value with tsearch fixup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
Cc: "Zoltan Boszormenyi" <zb(at)cybertec(dot)at>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, "Hans-Juergen Schoenig" <hs(at)cybertec(dot)at>, "Magnus Hagander" <magnus(at)hagander(dot)net>
Subject: Re: float4/float8/int64 passed by value with tsearch fixup
Date: 2008-04-21 05:10:44
Message-ID: 27252.1208754644@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com> writes:
> On Mon, Apr 21, 2008 at 2:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Applied with revisions --- mostly, supporting configure-time control
>> over whether pass-by-value is used.

> Do we need buildfarm coverage of these options?

Wouldn't hurt, I guess, though it's not very urgent since the
non-default cases were default up till these patches.

Note that we are already exercising both ends of the
float8-byval option, so probably only --disable-float4-byval
is very interesting to test explicitly.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2008-04-21 08:31:12 Re: Testing pg_terminate_backend()
Previous Message Guillaume Smet 2008-04-21 04:51:25 Re: float4/float8/int64 passed by value with tsearch fixup