Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Should libedit be preferred to libreadline?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Seneca Cunningham <scunning(at)ca(dot)afilias(dot)info>
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-12-02 03:43:19
Message-ID: 27252.1133494999@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patchespgsql-ports
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Can't it just be --with-libedit?  That seems awfully verbose,
>> particularly seeing that configure doesn't handle switch abbreviation.

> The problem is that we need a clear way to say we don't want any line
> editing.  Right now we do it with --without-readline.  Also, we already
> test for libedit if we don't find readline.  Would we stop doing that? 

Well, we could rename --without-readline to --without-editing, but
I think this would just break people's existing expectations without
adding much.  I don't see a problem with documenting

	--with-libedit		prefer libedit over libreadline

and leaving the rest alone.

> Oh, one good thing is that the new configure 2.59 we are using throws an
> error now for invalid user-supplied configure options, rather than
> silently ignoring it like it used to.

Really?  I did "configure --with-bozo" and it didn't complain.  It
does barf on "--bozo", but the autoconf boys have been insistent for
more than a decade that accepting --with-anything is a feature not
a bug.  So I think --with-some-long-name is more user-unfriendly than
user-friendly.

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: Bruce MomjianDate: 2005-12-02 03:58:10
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Bruce MomjianDate: 2005-12-02 03:27:32
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

pgsql-hackers by date

Next:From: Greg Sabino MullaneDate: 2005-12-02 03:45:53
Subject: Re: Please let us know if you will come to the PostgreSQL Anniversary
Previous:From: Neil ConwayDate: 2005-12-02 03:37:26
Subject: Re: generalizing the planner knobs

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-12-02 03:58:10
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Bruce MomjianDate: 2005-12-02 03:27:32
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group