Skip site navigation (1) Skip section navigation (2)

Re: ecpg - GRANT bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Lee Kindness <lkindness(at)csl(dot)co(dot)uk>
Cc: pgsql-bugs(at)postgresql(dot)org, maves(at)csl(dot)co(dot)uk, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: ecpg - GRANT bug
Date: 2001-10-12 17:18:49
Message-ID: 27250.1002907129@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Lee Kindness <lkindness(at)csl(dot)co(dot)uk> writes:
> ***************
> *** 1693,1699 ****
  
>   GrantStmt:  GRANT privileges ON opt_table relation_name_list TO grantee_list opt_with_grant
>   				{
> ! 					$$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7);
>   				}
>   		;
  
> --- 1693,1699 ----
  
>   GrantStmt:  GRANT privileges ON opt_table relation_name_list TO grantee_list opt_with_grant
>   				{
> ! 					$$ = cat_str(7, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7);
>   				}
>   		;


Uh, isn't the correct fix

! 					$$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7, $8);

ISTM your patch loses the opt_with_grant clause.  (Of course the backend
doesn't currently accept that clause anyway, but that's no reason for
ecpg to drop it.)

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-10-12 17:22:54
Subject: Re: optimizer question
Previous:From: Tom LaneDate: 2001-10-12 17:14:38
Subject: Re: optimizer question

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2001-10-12 17:53:49
Subject: Re: Possible bug in ALTER TABLE RENAME COLUMN (PostgreSQL 7.1.3)
Previous:From: Lee KindnessDate: 2001-10-12 15:33:00
Subject: ecpg - GRANT bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group