Re: pgsql: Get rid of SET LOGGED indexes persistence kludge

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Get rid of SET LOGGED indexes persistence kludge
Date: 2014-11-15 17:51:57
Message-ID: 27238.1416073917@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>> Get rid of SET LOGGED indexes persistence kludge

> The buildfarm suggests that this patch fails under CLOBBER_CACHE_ALWAYS.

After a bit of study, the explanation is almost certainly that you can't
just do this in reindex_index:

+ /* Set the relpersistence of the new index */
+ iRel->rd_rel->relpersistence = persistence;

Probably the right fix is to add a persistence parameter to
RelationSetNewRelfilenode. The existing patch seems pretty
klugy without that anyway.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2014-11-15 22:54:13 pgsql: Emit msg re skipping ANALYZE for absent inh tree
Previous Message Tom Lane 2014-11-15 17:42:05 Re: pgsql: Get rid of SET LOGGED indexes persistence kludge