From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Magnus Hagander <magnus(at)hagander(dot)net>
Cc:
Andrew Dunstan <andrew(at)dunslane(dot)net>,
pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:
Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Date:
2010-07-08 16:37:43
Message-ID:
27190.1278607063@sss.pgh.pa.us (view raw or flat )
Thread:
2010-07-08 10:20:14 from mha(at)postgresql(dot)org (Magnus Hagander)
2010-07-08 15:04:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-08 15:11:50 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-08 15:33:56 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-08 15:39:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-08 15:42:57 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-10 20:23:17 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-07-10 20:29:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-10 22:05:10 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-07-12 10:05:10 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-08 15:45:41 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-07-08 16:06:57 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-08 16:20:17 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-08 16:37:43 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-08 16:42:18 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-07-08 16:46:42 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-committers pgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Here's what I came up with and will apply as soon as my msvc build
> completes. (the mingw one works with this)
This is still going to need manual adjustment in the future, since
probably when mingw adds the #define, they will put it in <mstcpip.h>,
and this code will not see it. So at some point we'll need to add an
autoconf test for <mstcpip.h> and replace those #ifdef
WIN32_ONLY_COMPILER checks with #ifdef HAVE_MSTCPIP_H. But I see no
need to bother until such a version of mingw exists, and I'd just as
soon not be making such changes on the day of a wrap. So this is just
a note for later.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Magnus HaganderDate: 2010-07-08 16:42:18
Subject : Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous :From : Robert HaasDate : 2010-07-08 16:29:47
Subject : Re: Reviewfest 2010-06 Plans and Call for Reviewers
pgsql-committers by date
Next :From: Andrew DunstanDate: 2010-07-08 16:40:02
Subject : Re: pgsql: Make the Windows tcp keepalive support depend
on the existance of
Previous :From : Tom LaneDate : 2010-07-08 16:30:13
Subject : pgsql: Add a cross-reference to precedence information to CREATE