Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Sigh ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Date: 2008-05-02 23:23:34
Message-ID: 26929.1209770614@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> This doesn't look quite right; unless the arithmetic is being done in
>> floating point?  I had it like this in configure.in:
>> 
>> RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`

> blocksize is one of (1,2,4,8,16,32)  so it should always be a factor of 
> 1024 unless my arithmetic is awry. I did it that way because I dislike 
> expressions with  unbracketed mixed operations - they make me think too 
> much.

Well, if you dislike the original on style grounds, you should change it
to match.  Doing the same thing in two different ways in two places
isn't good.

>> Also it looks like you missed adding segsize to the config.pl comments.

> That's deliberate - we are currently only allowing a value of 1 here, so 
> I don't see any point in putting it in the sample config file, even as a 
> comment. When we enable other seg sizes we can add it to the sample file.

Ah, OK.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2008-05-03 00:26:29
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Tom LaneDate: 2008-05-02 23:19:00
Subject: Re: ecpg localization

pgsql-committers by date

Next:From: Tom LaneDate: 2008-05-03 00:11:36
Subject: pgsql: Support RETURN QUERY EXECUTE in plpgsql.
Previous:From: Andrew DunstanDate: 2008-05-02 23:05:05
Subject: Re: [COMMITTERS] pgsql: Sigh ...

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-05-02 23:24:21
Subject: Re: Exposing keywords to clients
Previous:From: Tom LaneDate: 2008-05-02 23:05:52
Subject: Re: plpgsql CASE statement - last version

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group