| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: SunOS patch for memcmp() |
| Date: | 2001-12-19 19:58:48 |
| Message-ID: | 2687.1008791928@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> At a glance, this patch looks okay. However, since this issue does not
> represent a regression from 7.1 I'm not exactly in favour of installing it
> now. We want to get a release out, so I think we need to get stricter in
> those matters. And this patch is not exactly trivial.
You're being way too harsh on it. The configure test is exactly the
standard AC_FUNC_MEMCMP test, tweaked to output its result the same way
our other port inclusions do. The memcmp implementation is also well
tested, being lifted from NetBSD. Where's the problem?
Clearly it should be tested, and I presume Tatsuo will do that,
but my vote is to apply it. Why should we drop SunOS off the list
of supported ports?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Owens | 2001-12-19 20:28:14 | Re: Connection Pooling, a year later |
| Previous Message | Peter Harvey | 2001-12-19 19:38:29 | Re: long ints use for 4-byte entities in ODBC |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2001-12-20 01:45:53 | Re: SunOS patch for memcmp() |
| Previous Message | Bruce Momjian | 2001-12-19 19:01:40 | Re: SunOS patch for memcmp() |