Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pg_dump --comment?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Jon Jensen <jon(at)endpoint(dot)com>,Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>,Chris Campbell <chris(at)bignerdranch(dot)com>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_dump --comment?
Date: 2004-06-04 13:43:53
Message-ID: 26695.1086356633@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> What happens in a pg_dump -Fc / pg_restore scenario?

> So, in non-ascii format, I need to dump a comment record and read it
> back on restore?  Yuck.  Anyone want to tackle that?

Yes.  Hacking the output routines alone is almost never the right way
to do things in pg_dump.

My feeling is that if anyone cares to tackle this, it would be
appropriate to add a record type that carries a user-supplied
comment, and then people could do something like
	pg_dump --comment "generated on `date`"
if they want to have a timestamp.  I don't want a timestamp put
into the file by default, because that creates problems for
comparing dump files.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2004-06-04 13:57:48
Subject: Re: upper() / lower() regression test case needed?
Previous:From: Andreas PflugDate: 2004-06-04 13:36:52
Subject: Re: Compiling libpq with VisualC

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-06-05 04:57:42
Subject: Re: [HACKERS] pg_dump --comment?
Previous:From: Andreas PflugDate: 2004-06-04 13:36:52
Subject: Re: Compiling libpq with VisualC

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group