Skip site navigation (1) Skip section navigation (2)

Re: vacuum hint on elog

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: vacuum hint on elog
Date: 2005-01-23 03:31:13
Message-ID: 26591.1106451073@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> Tom Lane wrote:
>> The code beginning at freelist.c line 645 is intended to deal with this.

> Ah, good point -- sorry, I missed that. The code as-is should be fine, then.

Well, one point is that the flag bit is checked elsewhere in the same
file without similar code to see if it's stale.  I'm not sure if the
other places can be reached without having reached line 645 first.

I tend to agree with Alvaro that a cleaner approach would be to PG_TRY
around the places that can set the flag, and get rid of the cleanup
logic at line 645.  We didn't have PG_TRY when that code was written,
but we do now ...

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-01-23 04:59:01
Subject: Re: uptime function to postmaster
Previous:From: Tom LaneDate: 2005-01-23 03:24:41
Subject: Re: [PATCHES] Merge pg_shadow && pg_group -- UNTESTED

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group