| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Michael Meskes <meskes(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: ecpg thread-safe descriptor |
| Date: | 2007-10-02 20:07:06 |
| Message-ID: | 26528.1191355626@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Michael Meskes wrote:
>> So, does an explicit export list help? If so I'm all for it. There is no
>> need to export all symbols. I always tried to keep the number of symbols
>> that get exported but are not needed low. So this will give the best
>> result possible.
> Yeah, it does seem to fix it.
That's very good news. If Michael can put together an export list
soon then we'll be in good shape.
Michael: you should bump the major version number of ecpglib when you do
this. Removing the not-officially-exported visible symbols *is* an ABI
break. You may think there isn't anything depending on them, but
remember how we thought that (twice) for libpq too. Bumping the major
version number will be cheap insurance against complaints later.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannes Eder | 2007-10-02 21:45:51 | minor compiler warning in libpg/fe-secure.c on win32 (msvc) |
| Previous Message | Magnus Hagander | 2007-10-02 19:50:15 | Re: ecpg thread-safe descriptor |