| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] rmtree() failure on Windows |
| Date: | 2004-10-28 00:41:54 |
| Message-ID: | 26443.1098924114@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> Try putting "RequestCheckpoint(true)" in dbcommands.c just before
>> remove_dbtablespaces (about line 630).
> seems to do the trick. patch attached.
Patch applied.
>> Not necessary, as long as you put the checkpoint after the DropBuffers
>> call in dbcommands.c. The bgwriter won't find anything to write.
> What about other databases? Or won't the forced checkpoint affect them?
For them, it's just an ordinary checkpoint. It's kind of a brute-force
solution, but I'm disinclined to worry about optimizing DROP DATABASE ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Buttafuoco | 2004-10-28 00:57:12 | Beta 4 on Debian Sarge (MIPS/MIPSEL) |
| Previous Message | Andrew Dunstan | 2004-10-28 00:23:03 | Re: [HACKERS] rmtree() failure on Windows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2004-10-28 01:39:25 | Re: pgstat cleanup: use palloc and AllocateFile |
| Previous Message | Andrew Dunstan | 2004-10-28 00:23:03 | Re: [HACKERS] rmtree() failure on Windows |