Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment
Date: 2004-07-12 18:44:29
Message-ID: 26430.1089657869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> Use strdup in pg_ctl for canonicalize_path on environment variable.
> Simplify postmaster call too.

You're not doing very well with this project :-(. pg_ctl is now
actively broken, because the PGDATA value passed down to the
bootstrap backend is the one in the environment variable. The
previous coding canonicalized that, this does not.

I do not like the "simplified" postmaster.c coding either; it may
save one line but it is harder to understand.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Mha 2004-07-12 19:04:30 pginstaller - pginst: Initdb integration code.
Previous Message Bruce Momjian 2004-07-12 18:17:17 pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment