Skip site navigation (1) Skip section navigation (2)

Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment
Date: 2004-07-12 18:44:29
Message-ID: 26430.1089657869@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> Use strdup in pg_ctl for canonicalize_path on environment variable. 
> Simplify postmaster call too.

You're not doing very well with this project :-(.  pg_ctl is now
actively broken, because the PGDATA value passed down to the
bootstrap backend is the one in the environment variable.  The
previous coding canonicalized that, this does not.

I do not like the "simplified" postmaster.c coding either; it may
save one line but it is harder to understand.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: User MhaDate: 2004-07-12 19:04:30
Subject: pginstaller - pginst: Initdb integration code.
Previous:From: Bruce MomjianDate: 2004-07-12 18:17:17
Subject: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group