Skip site navigation (1) Skip section navigation (2)

Re: BUG #4879: bgwriter fails to fsync the file in recovery mode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Date: 2009-06-25 19:03:22
Message-ID: 26353.1245956602@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
While nosing around the problem areas, I think I've found yet another
issue here.  The global bool InRecovery is only maintained correctly
in the startup process, which wasn't a problem before 8.4.  However,
if we are making the bgwriter execute the end-of-recovery checkpoint,
there are multiple places where it is tested that are going to be
executed by bgwriter.  I think (but am not 100% sure) that these
are all the at-risk references:
	XLogFlush
	CheckPointMultiXact
	CreateCheckPoint (2 places)
Heikki's latest patch deals with the tests in CreateCheckPoint (rather
klugily IMO) but not the others.  I think it might be better to fix
things so that InRecovery is maintained correctly in the bgwriter too.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2009-06-25 19:10:05
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Previous:From: Simon RiggsDate: 2009-06-25 19:02:03
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recoverymode

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group