Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Sigh ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Date: 2008-05-02 22:28:41
Message-ID: 26232.1209767321@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> ! 		print O "#define RELSEG_SIZE ",
> ! 			(1024 / $self->{options}->{blocksize}) * 
> ! 				$self->{options}->{segsize} * 1024, "\n";

This doesn't look quite right; unless the arithmetic is being done in
floating point?  I had it like this in configure.in:

RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`

Also it looks like you missed adding segsize to the config.pl comments.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2008-05-02 23:05:05
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Andrew DunstanDate: 2008-05-02 22:18:29
Subject: Re: [COMMITTERS] pgsql: Sigh ...

pgsql-committers by date

Next:From: Tom LaneDate: 2008-05-02 22:50:21
Subject: pgsql: Update documentation for psql relation-size-in-\dt+ patch.
Previous:From: Andrew DunstanDate: 2008-05-02 22:18:29
Subject: Re: [COMMITTERS] pgsql: Sigh ...

pgsql-patches by date

Next:From: Andrew DunstanDate: 2008-05-02 23:05:05
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Andrew DunstanDate: 2008-05-02 22:18:29
Subject: Re: [COMMITTERS] pgsql: Sigh ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group