Re: psql \! WIN32 cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: psql \! WIN32 cleanup
Date: 2004-11-06 05:30:55
Message-ID: 26227.1099719055@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The attached applied patch tests for COMSPEC in the right place and
> supplies a reasonable shell default on Win32.

> + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"

Is it really a good idea to assume that the Windows installation is on
drive C: ?

(This is an honest question, not a rhetorical one. I dunno whether
inserting the C: is better than leaving it off. I can think of cases
where either way will break, but I'm unsure what's most likely in
practice.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-11-06 05:49:56 Re: [PATCHES] psql \! WIN32 cleanup
Previous Message Bruce Momjian 2004-11-06 04:29:44 psql \! WIN32 cleanup

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-11-06 05:43:51 Re: ON COMMIT and foreign keys
Previous Message Alvaro Herrera 2004-11-06 04:55:12 ON COMMIT and foreign keys