Re: Use non-deprecated APIs for dynloader/darwin.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Chris Campbell <chris(at)bignerdranch(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Use non-deprecated APIs for dynloader/darwin.c
Date: 2006-10-08 18:29:25
Message-ID: 26187.1160332165@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Chris Campbell <chris(at)bignerdranch(dot)com> writes:
> Mac OS X has included dlopen() and friends etc since Mac OS X 10.3.
> The attached patch switches to using those APIs in src/backend/port/
> dynloader/darwin.c (and passes "make check").

Looks good, but I don't think we want to abandon OSX 10.2 support
just yet. I'll revise this to use a configure probe for dlopen.

My inclination is to apply this one now, since it only affects OSX
and should be easily testable, but to hold off on your other patch
for portable Bonjour support until 8.3 devel starts. The portability
implications of that one are unclear, and I don't know how to test it
either, so I think putting it in now is too much risk.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-10-08 18:33:52 Re: [COMMITTERS] pgsql: Add include needed for new getrusage() call.
Previous Message Bruce Momjian 2006-10-08 18:14:03 Re: [COMMITTERS] pgsql: Add include needed for new

Browse pgsql-patches by date

  From Date Subject
Next Message Chris Campbell 2006-10-08 18:43:28 Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c
Previous Message Chris Campbell 2006-10-08 01:04:26 Use non-deprecated APIs for dynloader/darwin.c