Skip site navigation (1) Skip section navigation (2)

Re: BUG #6510: A simple prompt is displayed using wrong charset

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Law <exclusion(at)gmail(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6510: A simple prompt is displayed using wrong charset
Date: 2012-10-14 16:10:42
Message-ID: 26179.1350231042@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-generalpgsql-hackers
Alexander Law <exclusion(at)gmail(dot)com> writes:

> +#ifdef WIN32
> +	termin = fopen("CONIN$", "r");
> +	termout = fopen("CONOUT$", "w+");
> +#else
>  	termin = fopen(DEVTTY, "r");
>  	termout = fopen(DEVTTY, "w");
> +#endif
>  	if (!termin || !termout

My immediate reaction to this patch is "that's a horrible kluge, why
shouldn't we change the definition of DEVTTY instead?"  Is there a
similar issue in other places where we use DEVTTY?

Also, why did you change the termout output mode, is that important
or just randomness?

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2012-10-14 16:10:55
Subject: Re: [PATCH] Make pg_basebackup configure and start standby [Review]
Previous:From: Fujii MasaoDate: 2012-10-14 16:02:20
Subject: Re: [PATCH] Make pg_basebackup configure and start standby [Review]

pgsql-bugs by date

Next:From: Josh KupershmidtDate: 2012-10-14 16:56:46
Subject: Re: pg_ctl restart issue with relative paths
Previous:From: Craig RingerDate: 2012-10-14 13:45:44
Subject: Re: Sorry to bother you. Please tell me exactly how the compiler was built ODBC

pgsql-general by date

Next:From: Arturo Pie JoaDate: 2012-10-14 19:49:58
Subject: Using incorrect default-value type
Previous:From: Alexander LawDate: 2012-10-14 06:35:04
Subject: Re: BUG #6510: A simple prompt is displayed using wrong charset

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group