Skip site navigation (1) Skip section navigation (2)

Re: Logging configuration changes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Logging configuration changes
Date: 2009-08-27 02:13:11
Message-ID: 26173.1251339191@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On sn, 2009-07-12 at 22:55 +0300, Peter Eisentraut wrote:
>> On occasion, I would have found it useful if a SIGHUP didn't only log *that*
>> it reloaded the configuration files, but also logged *what* had changed 
>> (postgresql.conf changes in particular, not so much interested in 
>> pg_hba.conf).  Especially in light of the common mistake of forgetting to 
>> uncomment a changed value, this would appear to be useful.

> Looked into this, looks trivial, except that this would log *all*
> parameters that were set as a result of a reload, instead of only the
> ones that changed.  We don't have the information of what it was
> previously readily available.

> I think it would still be useful that way, but some people might find it
> annoying.

Seems to me it would be too chatty to be useful, at least for people who
set more than one or two things in postgresql.conf.  Would it be that
hard to track which values actually changed?  Without having looked at
the code, I'm thinking that much of the infrastructure must be there
already now that we have support for undoing commented-out settings.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-08-27 02:23:55
Subject: Re: pretty print viewdefs
Previous:From: Bruce MomjianDate: 2009-08-27 02:10:55
Subject: Re: [COMMITTERS] pgsql: Update release notes for 7.4.26, 8.0.22, 8.1.18, 8.2.14, 8.3.8,

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group