Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow().
Date: 2007-01-06 04:07:37
Message-ID: 26099.1168056457@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Actually, when you return ERANGE, what is 'result'?  Nan?  Inf?  finite?

I believe it's HUGE_VAL (the largest finite value) ... which is
something I don't want to explicitly test for, any more than I liked
the explicit use of min/max values before.  Your isinf test is OK
because the point is that we want to replace any non-Inf result with Inf
if the result overflowed.

			regards, tom lane

In response to

pgsql-committers by date

Next:From: Bruce MomjianDate: 2007-01-06 04:14:55
Subject: pgsql: Improve dpow() check for ERANGE overflow for HPPA.
Previous:From: Bruce MomjianDate: 2007-01-06 04:01:51
Subject: Re: [COMMITTERS] pgsql: Put back ERANGE test in

pgsql-patches by date

Next:From: Gurjeet SinghDate: 2007-01-06 04:48:45
Subject: Re: A patch to pg_regress for Windows port
Previous:From: Joshua D. DrakeDate: 2007-01-06 04:05:56
Subject: Re: [HACKERS] wal_checksum = on (default) | off

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group