Skip site navigation (1) Skip section navigation (2)

Re: Fix for _outAgg()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix for _outAgg()
Date: 2008-01-09 04:08:43
Message-ID: 26088.1199851723@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> Attached is a patch which fixes an oversight in _outAgg(): the
> "grpColIdx" and "grpOperators" fields of the Agg struct were not emitted
> by _outAgg(). I don't see any good reason to omit this information.

Hmm, I think that must be my fault, but I'm not sure how it got by me
... I'm usually pretty careful about adding outfuncs support when I add
a node field.  Patch looks good, please apply.

> Note that while the "grpOperators" field was added during the 8.3 devel
> cycle, the "grpColIdx" field has been around since '02 (without outfuncs
> support). So I can backpatch that portion of the patch to back branches
> if anyone feels strongly.

Not worth backpatching --- the plan node output support is only of
interest to hard-core hackers, who'd be working on current sources.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Hiroshi SaitoDate: 2008-01-09 05:40:42
Subject: Re: win32.mak patch
Previous:From: Neil ConwayDate: 2008-01-09 03:14:48
Subject: Fix for _outAgg()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group