Re: libpq.dll on win32

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq.dll on win32
Date: 2004-10-12 00:37:46
Message-ID: 26050.1097541466@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:

*** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 -0000 1.54
--- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50:22 -0000
***************
*** 1201,1206 ****
--- 1201,1212 ----
return NULL;
return conn->ssl;
}
+ #else
+ void *
+ PQgetssl(PGconn *conn)
+ {
+ return NULL;
+ }
#endif /* USE_SSL */


This seems like a good idea, but that particular approach to it will
draw an unprototyped-global-function warning on every non-SSL-enabled
compile ... please clean it up.

Also, I count 3 *.def files to be fixed, not two. (We really oughta
figure a way to generate them all from a single list file... can we
rely on sed(1) being available in all Windows build environments?)

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-10-12 01:08:21 Re: Static build of libpq fails
Previous Message Tom Lane 2004-10-11 23:34:10 Re: Casting INT4 to BOOL...