Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add support for TCP keepalives on Windows, both for backend and

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add support for TCP keepalives on Windows, both for backend and
Date: 2010-07-08 15:39:14
Message-ID: 26004.1278603554@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Seems pretty simple - mingw doesn't have support for this. We have two
> ways to deal with that I think:
> 1) Disable it on mingw.
> 2) Include it in our custom headers.

> For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as
> well as the definition of struct tcp_keepalive.

> We've done #2 before at least once, which worked well until mingw
> suddenly caught up and added it a while later. It's not like this is a
> new definition in windows, but we need to be ready for them to
> eventually do that.

Yeah.  I'm satisfied with doing #1 and waiting for them to fix it.

> I guess there is:
> 3) write an autoconf test and provide them only when mingw doesn't have it.
> if we're going with #3, I'll respectfully have to ask somebod yelse to
> write the autoconf test, that's beyond me I think :-)

An easy approximation would be to make the code #ifdef SIO_KEEPALIVE_VALS.
That would fail if the mingw guys decide to provide the #define without
adding the struct at the same time, but that seems moderately unlikely.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2010-07-08 15:42:57
Subject: Re: pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous:From: Kevin GrittnerDate: 2010-07-08 15:36:58
Subject: Re: Reviewfest 2010-06 Plans and Call for Reviewers

pgsql-committers by date

Next:From: Magnus HaganderDate: 2010-07-08 15:42:57
Subject: Re: pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous:From: Magnus HaganderDate: 2010-07-08 15:33:56
Subject: Re: pgsql: Add support for TCP keepalives on Windows, both for backend and

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group