Re: hstore ==> and deprecate =>

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: hstore ==> and deprecate =>
Date: 2010-06-09 16:02:27
Message-ID: 25930.1276099347@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> + if (!strcmp(oprName, "=>"))

BTW, project standard is to spell that like

> + if (strcmp(oprName, "=>") == 0)

The other way looks confusingly like a "not equal" test.

> + (errmsg("The use of => as an operator name is deprecated and may be disallowed in a future release.")));

Also, this doesn't follow message style guidelines. Possibly better:

errmsg("=> is deprecated as an operator name"),
errdetail("This name may be disallowed altogether in future versions of PostgreSQL.")

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-06-09 16:05:28 Re: Invalid YAML output from EXPLAIN
Previous Message Andrew Gierth 2010-06-09 16:02:03 Re: hstore ==> and deprecate =>