Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] snprintf causes regression tests to fail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql(at)mohawksoft(dot)com, Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] snprintf causes regression tests to fail
Date: 2005-02-28 20:58:04
Message-ID: 25924.1109624284@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Ah, the problem was introduced here:

Right, it was my fault.

> The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
> below the printf 64-bit tests.  This commited patch moves
> PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and
> just before printf 64-bit args are tested.

This patch breaks things in a different way: you should not have moved
the AC_LIBOBJ(snprintf) step.  Also you randomly placed the arg-control
test between a chunk of code and the comment describing same.

Corrected version committed.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-02-28 21:29:57
Subject: Re: [HACKERS] snprintf causes regression tests to fail
Previous:From: Bruce MomjianDate: 2005-02-28 20:35:18
Subject: Re: [HACKERS] snprintf causes regression tests to fail

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-02-28 21:29:57
Subject: Re: [HACKERS] snprintf causes regression tests to fail
Previous:From: Bruce MomjianDate: 2005-02-28 20:35:18
Subject: Re: [HACKERS] snprintf causes regression tests to fail

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2005-02-28 21:29:57
Subject: Re: [HACKERS] snprintf causes regression tests to fail
Previous:From: Bruce MomjianDate: 2005-02-28 20:35:18
Subject: Re: [HACKERS] snprintf causes regression tests to fail

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group