Skip site navigation (1) Skip section navigation (2)

Review of last summer's PITR patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers-pitr(at)postgresql(dot)org
Subject: Review of last summer's PITR patch
Date: 2004-02-12 02:41:38
Message-ID: 25856.1076553698@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-pitr
I've done some preliminary work on the PITR patch that J.R. Nield
developed last summer.  I've applied parts of it (in rather edited
form) but there are big chunks I think are not ready to go.  You
can see the original patch in pgsql-patches --- I sent it there
mostly to get it into the archives.

I have committed the parts that have to do with making the contents of
WAL more robust for PITR purposes; specifically, labeling WAL segment
files clearly, and adding WAL logging of file creation/deletion.

I have not committed the massive reorganization of xlog.c that appears
in J.R.'s patch; I think it's unnecessary and likely to introduce bugs
(certainly it would revert some recent bug fixes).

I have also not committed the ALTER SYSTEM BACKUP / ALTER SYSTEM RECOVER
commands that appear in the patch.  It is not clear to me that this
functionality belongs in the backend rather than separate management
utilities, and even if it does belong there, this doesn't seem a clean
way to do it.  On the backup side, it seems like this code is basically
reinventing the tar(1) command.  On the restore side, I don't care for
the "interactive command" implementation of ALTER SYSTEM RECOVER ---
that seems like it makes it unnecessarily hard to drive the recovery
process from another program.  I envision this process being controlled
by some kind of higher-level management utility, so I'd prefer to see a
program-friendly API instead of one designed for manual use.

Anyway, I'm hoping to see some discussion of what to do next and what
the PITR functionality ought to look like from a user's standpoint.

			regards, tom lane

Responses

pgsql-hackers-pitr by date

Next:From: Fred MoyerDate: 2004-02-12 11:47:18
Subject: Re: [HACKERS] PITR Dead right
Previous:From: Simon RiggsDate: 2004-02-11 21:10:02
Subject: Re: [HACKERS] PITR Dead right

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group