Skip site navigation (1) Skip section navigation (2)

Re: ISBN/ISSN/ISMN/EAN13 module

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Jeremy Kronuz" <kronuz(at)hotmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: ISBN/ISSN/ISMN/EAN13 module
Date: 2006-09-10 18:18:08
Message-ID: 25825.1157912288@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
"Jeremy Kronuz" <kronuz(at)hotmail(dot)com> writes:
> ... Tom, were you able to apply the patch without problems 
> ('cause this is one of the first times I post a patch in a mailing list.)

Um, no, doesn't work at all unfortunately:

$ patch --dry <~/ean.patch
patching file isn.c
patch: **** malformed patch at line 6: enum isn_type { INVALID, ANY, EAN13, ISBN, ISMN, ISSN, UPC };

$ 

It looks like the patch got whitespace-mangled in transit.  With many
mail programs it works better to add a patch as an attachment than
to try to include it directly in the message text.  Also, we usually
ask for diff -c rather than diff -u format ... I for one find it easier
to read.

Please sync the text-conversion issues and resubmit.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Mark DilgerDate: 2006-09-10 18:55:35
Subject: Re: Fixed length data types issue
Previous:From: Tom LaneDate: 2006-09-10 18:08:45
Subject: contrib uninstall scripts need some love

pgsql-patches by date

Next:From: Joshua D. DrakeDate: 2006-09-10 19:09:24
Subject: Re: contrib uninstall scripts need some love
Previous:From: Tom LaneDate: 2006-09-10 18:08:45
Subject: contrib uninstall scripts need some love

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group